Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstrings for additional methods in #2480 #2489

Merged
merged 6 commits into from
Nov 7, 2019
Merged

Add docstrings for additional methods in #2480 #2489

merged 6 commits into from
Nov 7, 2019

Conversation

smitsanghavi
Copy link
Collaborator

No description provided.

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Nov 5, 2019
@smitsanghavi smitsanghavi mentioned this pull request Nov 5, 2019
Merged
vtomole
vtomole approved these changes Nov 6, 2019
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smitsanghavi smitsanghavi added the Ready for Re-Review For when reviewers take their time. label Nov 7, 2019
@Strilanc Strilanc added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed Ready for Re-Review For when reviewers take their time. labels Nov 7, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 7, 2019
@CirqBot CirqBot merged commit 17d94cf into quantumlib:master Nov 7, 2019
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strilanc Strilanc Strilanc approved these changes

@vtomole vtomole vtomole approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@smitsanghavi @Strilanc @vtomole @googlebot @CirqBot