Use @dataclass for cirq.google.[De]SerializingArg #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strilanc
commented
Nov 5, 2019
cirq/google/op_deserializer.py
Outdated
| """Specification of the arguments to deserialize an argument to a gate. | ||
|
|
||
| Attributes: | ||
| Args: |
There was a problem hiding this comment.
I realize this looks silly. But in my experimentation sphynx only seemed to understand the Args section, not the Attributes section.
There was a problem hiding this comment.
you could try digging into the napoleon documentation to see if there's some flag you need to set. IIRC napoleon (used for turning google-style docstrings into sphinx/rst) has a lot of flags you can set
There was a problem hiding this comment.
Reverted attributes->args change (will address in later PR if needed)
mpharrigan
reviewed
Nov 6, 2019
cirq/google/op_serializer.py
Outdated
| ('gate_getter', | ||
| Union[str, Callable[['cirq.Gate'], arg_func_langs.ArgValue]]), | ||
| ('required', bool)])): | ||
| @dataclass |
There was a problem hiding this comment.
consider @dataclass(frozen=True) for immutability and hashability
mpharrigan
approved these changes
Nov 6, 2019
Strilanc
added
the
automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
dstrain115
approved these changes
Nov 6, 2019
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: There are merge conflicts. |
CirqBot
removed
automerge
# Conflicts: # cirq/google/serializable_gate_set.py
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.