Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various doc fixes #2497

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Various doc fixes #2497

merged 2 commits into from
Nov 5, 2019

Conversation

Strilanc
Copy link
Contributor

@Strilanc Strilanc commented Nov 5, 2019

  • Add a few missing doc strings
  • Fix some example sections coming before args/results
  • Fix a few missing Args
  • Change some type annotations to refer to exposed 'cirq.XXX' instead of local cirq.YYY.ZZZ.XXXX

@Strilanc
Various doc fixes
7a196be 
- Add a few missing doc strings
- Fix some example sections coming before args/results
- Fix a few missing Args
- Change some type annotations to refer to exposed 'cirq.XXX' instead of local cirq.YYY.ZZZ.XXXX
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Nov 5, 2019
viathor
viathor approved these changes Nov 5, 2019
View reviewed changes
Copy link
Collaborator

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment. Thanks for doing this!

cirq/linalg/transformations.py Show resolved Hide resolved
@Strilanc Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 5, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 5, 2019
dstrain115
dstrain115 approved these changes Nov 5, 2019
View reviewed changes
cirq/devices/noise_model.py
"""Applies noise to each qubit individually at the start of every moment.

This is the noise model that is wrapped around an operation when that
operation is given as "the noise to use" for a `NOISE_MODEL_LIKE` parameter.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "the noise to use"? Is this a specific parameter? Can we use something more precise if possible.

cirq/linalg/transformations.py Show resolved Hide resolved
@CirqBot CirqBot merged commit 9becde4 into master Nov 5, 2019
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 5, 2019
@CirqBot CirqBot deleted the doczar6 branch November 5, 2019 23:59
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrain115 dstrain115 dstrain115 approved these changes

@viathor viathor viathor approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Strilanc @dstrain115 @viathor @googlebot @CirqBot