Initial draft of ConvertToSycamore #2516
Conversation
dstrain115
commented
Nov 8, 2019
dstrain115
commented
- Port of ConvertToSycamore from cirq_internal
- Cleaned up format, mypy, deprecated commands
- Refactored various functions to try to clean them up.
- Got rid of half-pi only rotations
- Port of ConvertToSycamore from cirq_internal - Cleaned up format, mypy, deprecated commands - Refactored various functions to try to clean them up. - Got rid of half-pi only rotations
| yield (gate(q1) for gate in optimizers.single_qubit_matrix_to_gates(a_1)) | ||
|
|
||
|
|
||
| def zztheta(theta: float, q0: ops.Qid, q1: ops.Qid) -> ops.OP_TREE: |
| yield ops.Rz(theta / 2).on(q1) | ||
|
|
||
|
|
||
| def swap_zztheta(theta: float, q0: ops.Qid, q1: ops.Qid) -> ops.OP_TREE: |
There was a problem hiding this comment.
I prefer the name swap_rzz.
|
Ping. Could I get a review of this? I would like to get this committed before the next import of google3 and to move away from the need for cirq_internal. Thanks. |
Done. Also cleaned up a bunch of tests to make them parameterized and got rid of a bunch of unnecessary cruft. Want to take another look before I submit? |
…irq-1 into convert_to_sycamore
|
Sorry to be a diva, but is there any way we could keep some (most) of the functions as free functions (i.e. not methods on a class)? They're really helpful atoms for crafting one's own optimizer if one is not happy with how At present, the only usage of |
I have changed them all to class methods or staticmethods. That way you can call them without instantiating the class. That to me seems better than having a bunch of loose functions hanging around. What do you think? |
