Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NoisySingleQubitReadoutSampler test class #2563

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Fix NoisySingleQubitReadoutSampler test class #2563

merged 2 commits into from
Nov 19, 2019

Conversation

kevinsung
Copy link
Collaborator

The test class was written incorrectly in that it only flips the first bit of each measurement. This didn't matter for how it was used, but still the test class should be correct.

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Nov 18, 2019
@kevinsung kevinsung mentioned this pull request Nov 18, 2019
Closed
Strilanc
Strilanc approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't worry too much about test classes being partial. Tests are all about partial implementations. But LGTM. I would also have accepted simply asserting that the qubit count was 1.

@kevinsung kevinsung added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 19, 2019
@CirqBot
Copy link
Collaborator

CirqBot commented Nov 19, 2019

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 19, 2019
@kevinsung kevinsung added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 19, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 19, 2019
@CirqBot CirqBot merged commit c055eea into quantumlib:master Nov 19, 2019
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 19, 2019
@kevinsung kevinsung deleted the fix_readout branch November 23, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strilanc Strilanc Strilanc approved these changes

@mpharrigan mpharrigan Awaiting requested review from mpharrigan

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevinsung @CirqBot @Strilanc @googlebot