-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AQT: Improve documentation, Add Z operations and rename AQTRemoteSimulator to AQTSamplerLocalSimulator #2578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2579 can be handled in a different PR.
Improved documentation
Improved documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes look good, with little formatting inconsistencies here and there.
There seems to be an issue with the Travis test. The pytest-changed-files produces following error:
|
I see the same issue on my local machine.
Should I open an issue for this? |
@pschindler Merged in #2584 and into your branch. That check passes here now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requested changes have been addressed.
The API for the AQT devices has been changed and should now be stable. The code for accessing the API has been changed and handling of connection errors has been improved.
This PR adds Z operations for the AQT device.
This PR addresses the issues #2194 #2091
The documentation has been imroved, possible addressing #2503