Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AQT: Improve documentation, Add Z operations and rename AQTRemoteSimulator to AQTSamplerLocalSimulator #2578

Merged
merged 17 commits into from
Nov 21, 2019

Conversation

pschindler
Copy link
Collaborator

@pschindler pschindler commented Nov 20, 2019

The API for the AQT devices has been changed and should now be stable. The code for accessing the API has been changed and handling of connection errors has been improved.

This PR adds Z operations for the AQT device.

This PR addresses the issues #2194 #2091

The documentation has been imroved, possible addressing #2503

Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2579 can be handled in a different PR.

cirq/aqt/aqt_device.py Show resolved Hide resolved
cirq/aqt/aqt_device.py Outdated Show resolved Hide resolved
cirq/aqt/aqt_device.py Outdated Show resolved Hide resolved
@vtomole vtomole changed the title AQT Api update AQT: Improve documentation, Add Z operations and rename AQTRemoteSimulator to AQTSamplerLocalSimulator Nov 20, 2019
Copy link
Contributor

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes look good, with little formatting inconsistencies here and there.

cirq/aqt/aqt_device.py Show resolved Hide resolved
cirq/aqt/aqt_device.py Outdated Show resolved Hide resolved
cirq/aqt/aqt_device.py Outdated Show resolved Hide resolved
cirq/aqt/aqt_device.py Outdated Show resolved Hide resolved
@pschindler
Copy link
Collaborator Author

There seems to be an issue with the Travis test. The pytest-changed-files produces following error:

========================= no tests ran in 0.00 seconds =========================
ERROR: file not found: cirq/aqt/aqt_sampler_test.py
cirq/aqt/aqt_simulator_test.py
The command "check/pytest-changed-files" exited with 4.

https://travis-ci.com/quantumlib/Cirq/jobs/258921745

@pschindler
Copy link
Collaborator Author

pschindler commented Nov 21, 2019

I see the same issue on my local machine.
There seems to be an issue with check/pytest-changed-files
If I remove the " from the last line, it seems to work:

pytest ${rest} ${changed[@]}

Should I open an issue for this?

@vtomole
Copy link
Collaborator

vtomole commented Nov 21, 2019

@pschindler Merged in #2584 and into your branch. That check passes here now.

Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtomole vtomole dismissed Strilanc’s stale review November 21, 2019 16:10

Requested changes have been addressed.

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 21, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 21, 2019
@CirqBot CirqBot merged commit 2201aa0 into quantumlib:master Nov 21, 2019
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants