Fix instability in _decompose_interaction_into_two_b_gates_ignoring_single_qubit_ops #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Strilanc
commented
Dec 2, 2019
Strilanc
commented
- In the windows tests, values were going slightly outside the input ranges of inverse trig functions
…ingle_qubit_ops - In the windows tests, values were going slightly outside the input ranges of inverse trig functions
|
Must verify that the windows tests are not printing out warnings now. |
mpharrigan
approved these changes
Dec 11, 2019
| a2 = max(0.0, min(1, a2)) # Clamp out-of-range floating point error. | ||
| b2 = np.arcsin(np.sqrt(a2)) | ||
| r = max(0.0, r) # Clamp out-of-range floating point error. | ||
| if r > 0.499999999999: |
There was a problem hiding this comment.
replace constant with 0.5 - EPS?
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.