Add random quantum circuit generation #2621

kevinsung · 2019-12-05T01:25:05Z

Adapted from pyle.

Let me know if the name random_quantum_circuit is too generic. What would be a better name?

kevinsung · 2019-12-05T18:49:28Z

mypy complains

cirq/experiments/random_quantum_circuit.py:224: error: List comprehension has incompatible type List[Operation]; expected List[GateOperation]

but #2626

kevinsung · 2019-12-05T19:49:28Z

Actually I modified the code so mypy no longer complains.

Strilanc · 2020-01-23T00:00:37Z

cirq/experiments/__init__.py

@@ -30,6 +30,13 @@
    xeb_fidelity,
 )

+from cirq.experiments.random_quantum_circuit import (


The name of this code needs to be more descriptive. "Random quantum circuit" can mean a lot of things. Make it like "random_rotations_between_interaction_layers" or something. Be as descriptive as possible... although the name should fit on a line.

I think we could keep the module name as is or perhaps just add "generation" to it (as in random_quantum_circuit_generation or random_circuit_generation) with the intention for any future RQC-generation code to be added here as well.

I renamed the module to random_quantum_circuit_generation

@Strilanc you okay with @viathor's suggestion?

cirq/experiments/random_quantum_circuit_test.py

cirq/experiments/random_quantum_circuit.py

viathor · 2020-01-23T00:51:21Z

cirq/experiments/__init__.py

@@ -30,6 +30,13 @@
    xeb_fidelity,
 )

+from cirq.experiments.random_quantum_circuit import (


I think we could keep the module name as is or perhaps just add "generation" to it (as in random_quantum_circuit_generation or random_circuit_generation) with the intention for any future RQC-generation code to be added here as well.

viathor · 2020-01-23T00:52:56Z

cirq/experiments/__init__.py

+    GMON_EASY_PATTERN,
+    GMON_HARD_PATTERN,
+    GmonLayer,
+    random_quantum_circuit,


As suggested by @Strilanc above, we should name this more specific. This will also make the module future-proof by preventing name collisions. Example name for the function: make_layered_random_circuit.

I renamed it random_rotations_between_grid_interaction_layers_circuit.

kevinsung · 2020-02-03T22:25:01Z

Windows build is failing.

viathor

LGTM, with some minor nits.

cirq/experiments/__init__.py

cirq/experiments/random_quantum_circuit_generation.py

viathor · 2020-02-06T23:29:55Z

cirq/experiments/random_quantum_circuit_generation.py

+        single_qubit_gates: Sequence['cirq.Gate'],
+        previous_single_qubit_layer: Dict['cirq.GridQubit', 'cirq.Gate'],
+        prng: 'np.random.RandomState',
+) -> Dict['cirq.GridQubit', 'cirq.Gate']:


For defense-in-depth, you could check consistency of qubits and previous layer:

if not previous_single_qubit_layer and set(qubits) != set(previous_single_qubit_layer.keys()): raise ValueError(...)

I think you put the not there by mistake. I think this is quite unnecessary; I'd rather omit it.

CirqBot · 2020-02-07T01:16:11Z

Automerge cancelled: Need a fresh 🍪.

CirqBot · 2020-02-07T01:17:02Z

Automerge cancelled: The automerge label was removed.

cirq/experiments/random_quantum_circuit.py

Comment addressed.

stale

CirqBot · 2020-02-12T19:15:46Z

Automerge cancelled: Need a fresh 🍪.

CirqBot · 2020-02-12T19:16:42Z

Automerge cancelled: The automerge label was removed.

add random quantum circuit generation

b0eed78

kevinsung requested review from Strilanc and viathor December 5, 2019 01:25

googlebot added the cla: yes Makes googlebot stop complaining. label Dec 5, 2019

kevinsung added 2 commits December 4, 2019 17:34

sort docs/api.rst

791c1f3

type

bf15262

use gate dict instead of op list

4b59577

lint

0cbc0ff

Strilanc previously requested changes Jan 23, 2020

View reviewed changes

viathor requested changes Jan 23, 2020

View reviewed changes

kevinsung added 5 commits January 31, 2020 17:02

Merge branch 'master' into xeb_circuit

fd66779

rename file, method, and constant names and docs

c32eeaf

rename main function and improve test

007cac9

fix docs/api.rst

bd1ebc0

fix types

272bb57

kevinsung added the Ready for Re-Review For when reviewers take their time. label Feb 3, 2020

increase test circuit depth

97c9f91

viathor approved these changes Feb 6, 2020

View reviewed changes

rename PARALLEL to ALIGNED

3134cd1

kevinsung added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 7, 2020

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 7, 2020

CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 7, 2020

Merge branch 'master' into xeb_circuit

31b20f5

CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 7, 2020

vtomole previously requested changes Feb 7, 2020

View reviewed changes

cirq/experiments/random_quantum_circuit.py Outdated Show resolved Hide resolved

kevinsung added 3 commits February 10, 2020 14:14

add copyright and license

555842a

Merge branch 'xeb_circuit' of github.com:kevinsung/Cirq into xeb_circuit

4b63120

make final single qubit layer optional and improve doc

50cb015

kevinsung added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 12, 2020

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 12, 2020

CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 12, 2020

CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 12, 2020

kevinsung and others added 4 commits February 12, 2020 12:35

add module docstring

2849b00

Merge branch 'master' into xeb_circuit

94953a0

format

23ce2b3

Merge branch 'xeb_circuit' of github.com:kevinsung/Cirq into xeb_circuit

81e7db3

kevinsung merged commit ce13a73 into quantumlib:master Feb 12, 2020

kevinsung deleted the xeb_circuit branch February 12, 2020 22:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add random quantum circuit generation #2621

Add random quantum circuit generation #2621

kevinsung commented Dec 5, 2019

kevinsung commented Dec 5, 2019

kevinsung commented Dec 5, 2019

Strilanc Jan 23, 2020

viathor Jan 23, 2020

kevinsung Feb 3, 2020

kevinsung Feb 7, 2020 •

edited

viathor Jan 23, 2020

viathor Jan 23, 2020

kevinsung Feb 3, 2020

kevinsung commented Feb 3, 2020

viathor left a comment

viathor Feb 6, 2020

kevinsung Feb 7, 2020

CirqBot commented Feb 7, 2020

CirqBot commented Feb 7, 2020

CirqBot commented Feb 12, 2020

CirqBot commented Feb 12, 2020

Add random quantum circuit generation #2621

Add random quantum circuit generation #2621

Conversation

kevinsung commented Dec 5, 2019

kevinsung commented Dec 5, 2019

kevinsung commented Dec 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevinsung Feb 7, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevinsung commented Feb 3, 2020

viathor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CirqBot commented Feb 7, 2020

CirqBot commented Feb 7, 2020

CirqBot commented Feb 12, 2020

CirqBot commented Feb 12, 2020

kevinsung Feb 7, 2020 •

edited