Fix documentation and key error in calibration #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Dec 10, 2019
dstrain115
commented
- Tried to retrieve historical calibration and it was broken.
- Fixed docs to my understanding and fixed key error.
- Please verify that this is correct now per the API.
- Tried to retrieve historical calibration and it was broken. - Fixed docs to my understanding and fixed key error. - Please verify that this is correct now per the API.
lindmarkm
approved these changes
Dec 10, 2019
cirq/google/engine/engine.py
Outdated
| @@ -737,15 +737,16 @@ def get_calibration(self, calibration_name: str) -> calibration.Calibration: | |||
|
|
|||
| Params: | |||
| calibration_name: A string of the form | |||
| `<processor name>/calibrations/<ms since epoch>` | |||
| `projects/<project_id>/processors/<processor name>` | |||
| `/calibrations/<ms since epoch>` | |||
There was a problem hiding this comment.
The original doc using is correct (except for the timestamp units) but I'm not certain what convention is being used here.
The full resource name for a calibration object is:
projects/<project id>/processors/<processor id>/calibrations/<timestamp in seconds since epoch>
There was a problem hiding this comment.
Yeah, it looks like you need the whole resource name or else it fails. Good catch on the units.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.