Change symbols in phased_iswap_test #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In sympy 1.2, print(1 - sympy.Symbol('t')) outputs "-t + 1"
- While the requirements do require sympy 1.4, the actual symbols used
in this test are not important to the testing of phased iswap, and this
change will simplify people who are forced to use older versions of
sympy (i.e. me).
vtomole
approved these changes
Jan 8, 2020
I'd have to go back and check, but I don't think that has a consistent printing in sympy either. I think that sympy 1.2 prints it as "1+t" but sympy 1.4 prints it as "t+1" |
# 1.2
>>> print(1 + sympy.Symbol('t'))
t + 1
>>> print(sympy.Symbol('t') + 1)
t + 1# 1 .4
>>> import sympy
>>> print(1 + sympy.Symbol('t'))
t + 1
>>> print(sympy.Symbol('t') + 1)
t + 1 |
olliahonen
pushed a commit
to iqm-finland/Cirq
that referenced
this pull request
Jan 10, 2020
* Change symbols in phased_iswap_test
- In sympy 1.2, print(1 - sympy.Symbol('t')) outputs "-t + 1"
- While the requirements do require sympy 1.4, the actual symbols used
in this test are not important to the testing of phased iswap, and this
change will simplify people who are forced to use older versions of
sympy (i.e. me).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this test are not important to the testing of phased iswap, and this
change will simplify people who are forced to use older versions of
sympy (i.e. me).