Add PhysicalZTag #2753
Merged
Add PhysicalZTag #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Feb 10, 2020
dstrain115
commented
- Simple class in cirq.google.ops that can denote physical Z gates.
- Just includes the class definition so far, no functionality.
- Simple class in cirq.google.ops that can denote physical Z gates. - Just includes the class definition so far, no functionality.
maffoo
approved these changes
Feb 12, 2020
cirq/google/ops/physical_z_tag.py
Outdated
| class PhysicalZTag: | ||
| """Class to add as a tag onto an Operation to denote a Physical Z operation. | ||
|
|
||
| By default, all Z rotations on Google devices are considered to be virtual. |
cirq/google/ops/physical_z_tag.py
Outdated
| tracking mechanisms, essentially commuting it forwards through the circuit | ||
| until it hits a non-commuting operation (Such as a sqrt(iSwap)). | ||
|
|
||
| By attaching this to a Z rotation operation, this class will denote to the |
There was a problem hiding this comment.
nit: "When applied to a Z rotation operation, this tag indicates to the hardware that..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.