Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Best Practices its own page #2754

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

dstrain115
Copy link
Collaborator

  • This looks like it may be better on its own page
  • This will also facilitate ease of modification as early uses
    will be able to add to this page more easily than if combined
    with other stuff.

- This looks like it may be better on its own page
- This will also facilitate ease of modification as early uses
will be able to add to this page more easily than if combined
with other stuff.
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Feb 10, 2020
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're on a roll!

See `cirq.google.arg_func_langs` for details.

The sympy library is also infamous for being slow, so avoid using complicated formulas if you
care about performance. Avoid using parameter resolvers that have formulas in them.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: does using the flatten capabilities tend to help this? Mentioning it here would probably be good if it does.

@dstrain115 dstrain115 merged commit 68ca843 into quantumlib:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants