Restore deprecated noise models. #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
My comment from the linked issue:
We should definitely keep them around until they can be replaced with composed noise models, at which point we should introduce shims with a deprecation warning
IMHO, I don't think we should even put the deprecation warning in now until we have better advice to give users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #2826, it won't be possible to use single-noise-type models to implement these aggregate models until the noise model composition story is solidified. For now, I've restored the models removed in #2734 (and associated tests) and marked them as deprecated.