Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantum engine gRPC path #2833

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Conversation

dstrain115
Copy link
Collaborator

@dstrain115 dstrain115 commented Mar 11, 2020

  • gRPC path was incorrectly changed to the cirq proto path (cirq.google.engine...)
  • It should be using the cloud path (google.cloud...)

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Mar 11, 2020
Copy link
Collaborator

@lindmarkm lindmarkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@maffoo
Copy link
Contributor

maffoo commented Mar 11, 2020

How is the grpc code generated? Is the script to do that checked in somewhere? Also, as an action item, we should consider adding a CI check that regenerates proto/grpc code and checks that there's no diff with what was committed.

@dstrain115
Copy link
Collaborator Author

How is the grpc code generated? Is the script to do that checked in somewhere? Also, as an action item, we should consider adding a CI check that regenerates proto/grpc code and checks that there's no diff with what was committed.

They just changed the procedure to generate this code and it is extremely complicated, involving blaze, bazel, and manual adjustments. It would be extremely difficult to do what you are asking.

That being said, I am hoping to put directions and part of the procedure into google3.

@dstrain115 dstrain115 merged commit 61b4259 into quantumlib:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants