Replace Travis with Github workflow except for script that performs `dev`builds #2859

vtomole · 2020-03-25T18:54:29Z

No description provided.

Strilanc · 2020-03-27T23:54:12Z

This looks awesome so far. Finally granular checkmarks again!

googlebot · 2020-03-30T19:00:03Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-03-30T19:20:48Z

☹️ Sorry, but only Googlers may change the label cla: yes.

googlebot · 2020-03-30T19:20:54Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2020-03-30T20:05:22Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

CirqBot · 2020-03-30T20:06:53Z

Automerge cancelled: No approved review.

googlebot · 2020-03-30T20:07:02Z

☹️ Sorry, but only Googlers may change the label cla: yes.

googlebot · 2020-04-01T17:57:24Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Strilanc · 2020-04-01T17:59:53Z

dev_tools/conf/pip-list-dev-tools.txt

@@ -29,4 +29,4 @@ ipython
 ipykernel

 # Need to pin pylint's parser to 2.1 instead of 2.2 until https://github.com/PyCQA/astroid/issues/650 is fixed
-astroid~=2.1.0
+astroid~=2.2.0


Instead of bumping the version, see if removing the pin works.

Strilanc · 2020-04-01T18:02:11Z

.github/workflows/publish-to-pypi.yml

+          python-version: '3.6'
+          architecture: 'x64'
+          user: quantumlibdev
+          password: KO3RuwLvjb5/J7akv2v/a9tEIbmErp7El6S+ZfMvDRlx8qpUfav1w4nvSGw6sfn837++2+F2Tb22wbJkjefpFMzg9mOdhFGwtOpiHSOnYlY2mnxVN9XdQnMS7F+8IMFas4J3EhqrlsZxoqyMy122S3pjtE/d6YSG+3YzmCu3rLsFl4EV6I5U8MgWJY8LDFqMIxuxgmEkJfPe5z9Sqqwtneelj39jobg4q1uZc0JD3rkI0hj/uhBvBoTTLQjPiZk3ZIkgkMmPVB8tDGK9eXqVuDK7U1ZoDWvTKNebZ94g46YuKVNY6tEJpgpacti6mMalva6wX8zYpWOrY0PPo34e5d/kfwkttnrMk+sPXJnvn5eM7tEWxF+PHz4ejcLEYpehgdbWksHaUVdPog7UrYXnertHDY42ukxF17JlU9rlf60IXJVmeYHTfB1p8V7Yfllgmfa49yGDnR68Y3iIR9NtT26ZoJnMAkrxvlTgz6poBbTKj+Gyr0pkTHLzniEo3D/C8xeVcD30yZPlXxCojcM4s2dM2h5IiQU//ubptP/TE0idG2AJiooEfGUsXZ+IbN4Zxvkoa4YzYCvYFlr42ZBnv0H5/xZc4uFK6rLcVtysZqWAj3QjVGIUX3G1sxy8ik+RSQun1Dhzov8v5RVtb6aShDWT6l6paAAEwrQNt0T44yo=


Pretty sure this is encrypted under a key that travis has, not github. I suggest moving the deploy over in a later step.

Strilanc

Check if they can run in parallel

googlebot · 2020-04-01T18:07:20Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-04-06T22:00:40Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-04-08T17:58:06Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

95-martin-orion · 2020-04-13T15:30:51Z

It looks like a Cirq repo owner will need to disable the Travis CI status check (described here) before this PR can be submitted. Pinging @Strilanc for this.

…o github_workflow

vtomole · 2020-04-15T19:58:45Z

@Strilanc Just confirmed that merging is blocked when checks fail.

Strilanc · 2020-04-15T22:41:32Z

👍👍👍👍👍👍👍

…dev`builds (quantumlib#2859)

googlebot added the cla: yes Makes googlebot stop complaining. label Mar 25, 2020

googlebot added cla: no and removed cla: yes Makes googlebot stop complaining. labels Mar 30, 2020

vtomole force-pushed the github_workflow branch from 5378c67 to 50622c4 Compare March 30, 2020 19:18

vtomole added the cla: yes Makes googlebot stop complaining. label Mar 30, 2020

googlebot removed the cla: yes Makes googlebot stop complaining. label Mar 30, 2020

googlebot added cla: yes Makes googlebot stop complaining. and removed cla: no labels Mar 30, 2020

vtomole force-pushed the github_workflow branch from 5335dfd to d60fcea Compare March 30, 2020 19:32

googlebot added cla: no and removed cla: yes Makes googlebot stop complaining. labels Mar 30, 2020

vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 30, 2020

CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 30, 2020

vtomole added the cla: yes Makes googlebot stop complaining. label Mar 30, 2020

googlebot removed the cla: yes Makes googlebot stop complaining. label Mar 30, 2020

Strilanc added the cla: yes Makes googlebot stop complaining. label Apr 1, 2020

googlebot removed the cla: no label Apr 1, 2020

Strilanc reviewed Apr 1, 2020

View reviewed changes

googlebot removed the cla: yes Makes googlebot stop complaining. label Apr 1, 2020

googlebot added cla: no and removed cla: yes Makes googlebot stop complaining. labels Apr 6, 2020

squash commits

c1907bd

vtomole force-pushed the github_workflow branch from e8514b5 to c1907bd Compare April 8, 2020 17:58

googlebot added cla: yes Makes googlebot stop complaining. and removed cla: no labels Apr 8, 2020

vtomole added 2 commits April 11, 2020 11:54

Move order

397b204

Moved changed files

717c237

vtomole requested review from Strilanc, dstrain115, 95-martin-orion, crystalzhaizhai and cduck April 11, 2020 17:04

vtomole changed the title ~~TESTING: Github workflow pylint~~ Replace Travis with Github workflow except for script that performs devbuilds Apr 12, 2020

Strilanc approved these changes Apr 15, 2020

View reviewed changes

vtomole and others added 3 commits April 15, 2020 14:10

break everything

3d1e9a7

Merge branch 'github_workflow' of https://github.com/vtomole/Cirq int…

5ab5e69

…o github_workflow

Merge branch 'master' into github_workflow

6a62a24

Revert

bdc3b39

vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 15, 2020

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 15, 2020

CirqBot merged commit 68bf299 into quantumlib:master Apr 15, 2020

CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 15, 2020

tanujkhattar pushed a commit to tanujkhattar/Cirq that referenced this pull request Apr 20, 2020

Replace Travis with Github workflow except for script that performs `…

75baa76

…dev`builds (quantumlib#2859)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Travis with Github workflow except for script that performs `dev`builds #2859

Replace Travis with Github workflow except for script that performs `dev`builds #2859

vtomole commented Mar 25, 2020

Strilanc commented Mar 27, 2020

googlebot commented Mar 30, 2020

googlebot commented Mar 30, 2020

googlebot commented Mar 30, 2020

googlebot commented Mar 30, 2020

CirqBot commented Mar 30, 2020

googlebot commented Mar 30, 2020

googlebot commented Apr 1, 2020

Strilanc Apr 1, 2020

Strilanc Apr 1, 2020

Strilanc left a comment

googlebot commented Apr 1, 2020

googlebot commented Apr 6, 2020

googlebot commented Apr 8, 2020

95-martin-orion commented Apr 13, 2020 •

edited

vtomole commented Apr 15, 2020

Strilanc commented Apr 15, 2020

Replace Travis with Github workflow except for script that performs devbuilds #2859

Replace Travis with Github workflow except for script that performs devbuilds #2859

Conversation

vtomole commented Mar 25, 2020

Strilanc commented Mar 27, 2020

googlebot commented Mar 30, 2020

googlebot commented Mar 30, 2020

googlebot commented Mar 30, 2020

googlebot commented Mar 30, 2020

CirqBot commented Mar 30, 2020

googlebot commented Mar 30, 2020

googlebot commented Apr 1, 2020

Strilanc Apr 1, 2020

Choose a reason for hiding this comment

Strilanc Apr 1, 2020

Choose a reason for hiding this comment

Strilanc left a comment

Choose a reason for hiding this comment

googlebot commented Apr 1, 2020

googlebot commented Apr 6, 2020

googlebot commented Apr 8, 2020

95-martin-orion commented Apr 13, 2020 • edited

vtomole commented Apr 15, 2020

Strilanc commented Apr 15, 2020

Replace Travis with Github workflow except for script that performs `dev`builds #2859

Replace Travis with Github workflow except for script that performs `dev`builds #2859

95-martin-orion commented Apr 13, 2020 •

edited