Add GridQid class #2861
Merged
Add GridQid class #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strilanc
reviewed
Mar 26, 2020
| >>> cirq.GridQubit(2, 3) - (1, 2) | ||
| cirq.GridQubit(1, 1) | ||
| """ | ||
| @functools.total_ordering |
There was a problem hiding this comment.
jbc that's what _BaseLineQid uses; I was confused bc it seemed like Qid implements all the rich comparison functions, but figured there was a reason for it to be there: possibly removable from both _BaseLineQid and _BaseGridQid?
There was a problem hiding this comment.
It might be a performance optimization somehow. But normally it requires you to define e.g. __lt__
…rns GridQid, corrected filename in helpful error
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GridQid class to match LineQid, to support grid systems with dimension !=2