Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix images in cirq docs #2876

Merged
merged 5 commits into from
Mar 31, 2020
Merged

Conversation

dstrain115
Copy link
Collaborator

  • Move images to an images directory
  • Also use relative links to force docs to add them.

- Move images to an images directory
- Also use relative links to force docs to add them.
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Mar 30, 2020
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah maybe the images can be consolidated into _static but otherwise this looks like a good fix. Do the images show up if you run the notebooks locally?

@dstrain115
Copy link
Collaborator Author

Where does _static(https://github.com/quantumlib/Cirq/tree/master/docs/_static) fit into this?

Changed the images to _static and moved the links back to absolute.

@dstrain115 dstrain115 merged commit d1d203e into quantumlib:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants