Add interop docs and optimizers #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Apr 2, 2020
dstrain115
commented
- Move QASM from circuits doc to a new interop page
- Add JSON and quirk functionality to interop page
- Add a section on optimizers to circuits page.
- Move QASM from circuits doc to a new interop page - Add JSON and quirk functionality to interop page - Add a section on optimizers to circuits page.
|
Ping. Would it be possible to get a review on this PR? |
vtomole
approved these changes
Apr 14, 2020
docs/circuits.ipynb
Outdated
| { | ||
| "cell_type": "markdown", | ||
| "metadata": { | ||
| "id": "77zB_UqkAwCR", | ||
| "colab_type": "text" | ||
| }, | ||
| "source": [ | ||
| "" | ||
| "" |
There was a problem hiding this comment.
Is this image not in latest? I thought we store all these things in static. Why the change in this link?
There was a problem hiding this comment.
Good catch. I think this was a merge issue of some sorts, since I changed this in an early PR.
I will also go and double-check other changes to make sure I am not squashing anything once I update the branch.
docs/circuits.ipynb
Outdated
| }, | ||
| "source": [ | ||
| "The following call will create a circuit defined by the input QASM string:" | ||
| "Optimizers will have a function `optimize_circuit()` that can be used to perform this optimization. Here is a simple example that removes moments that are empty:" |
There was a problem hiding this comment.
nit: change moments that are empty to empty moments
tanujkhattar
pushed a commit
to tanujkhattar/Cirq
that referenced
this pull request
Apr 20, 2020
* Add interop docs and optimizers - Move QASM from circuits doc to a new interop page - Add JSON and quirk functionality to interop page - Add a section on optimizers to circuits page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.