Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY radian formatting #2907

Merged
merged 9 commits into from
Apr 16, 2020
Merged

DRY radian formatting #2907

merged 9 commits into from
Apr 16, 2020

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Apr 14, 2020

Replace private functions _rads_func_symbol and _format_rads with a new public method CircuitDiagramInfoArgs.format_radians and re-use wherever appropriate.

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Apr 14, 2020
dstrain115
dstrain115 approved these changes Apr 16, 2020
View reviewed changes
cirq/ops/parity_gates.py Show resolved Hide resolved
@viathor viathor merged commit beaa782 into quantumlib:master Apr 16, 2020
@viathor viathor deleted the format_radians branch April 16, 2020 22:15
tanujkhattar pushed a commit to tanujkhattar/Cirq that referenced this pull request Apr 20, 2020
@viathor @tanujkhattar
DRY radian formatting (quantumlib#2907)
17062f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrain115 dstrain115 dstrain115 approved these changes

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@viathor @dstrain115 @googlebot @vtomole