Compare pauli matrices in commute using equality instead of is
#2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viathor
reviewed
Apr 17, 2020
There was a problem hiding this comment.
Two comments:
- Perhaps rather than making
commuteswork with multiple instances of each Pauli we could continue to use the single instance we have inPauli._XYZlike we do in some other methods in the class. - Could you add a test that captures the problem? It should fail before your change and succeed after it.
viathor
requested changes
Apr 22, 2020
|
Updated as per the suggestion. PTAL. |
viathor
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #2813