Add allow_decompose flag on has_channel #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use this flag in DensityMatrixSimulator to allow simulating operations that decompose into channels.
balopat
approved these changes
Aug 24, 2020
cirq/protocols/channel.py
Outdated
| decompose an object to check if it is unitary as part of determining | ||
| if the object is a quantum channel, when the quantum channel check | ||
| will already be doing a more general decomposition check). Defaults | ||
| to True. When false, the decomposition strategy for determining |
cirq/protocols/channel.py
Outdated
| @@ -20,6 +20,8 @@ | |||
| import numpy as np | |||
| from typing_extensions import Protocol | |||
|
|
|||
| from cirq.protocols.decompose_protocol import \ | |||
There was a problem hiding this comment.
nit: prefer parens over \ + newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use this flag in DensityMatrixSimulator to allow simulating operations that decompose into channels.