Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give mypy a hint #3271

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Give mypy a hint #3271

merged 1 commit into from
Aug 26, 2020

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Aug 26, 2020

Mypy asks for a hint:

$ ./check/all
Running misc
No issues.
Running pylint
Running mypy
dev_tools/auto_merge.py:154: error: Need type annotation for 'results'
Running incremental format                                             

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Aug 26, 2020
@viathor viathor merged commit 52a2c49 into quantumlib:master Aug 26, 2020
@viathor viathor deleted the type-hint-auto-merge branch August 26, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@balopat balopat Awaiting requested review from balopat

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viathor @vtomole @googlebot