-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation on bell_inequality.py example #3281
Conversation
Thanks for opening this @SamarthVadia , I'll review it tomorrow. |
examples/bell_inequality.py
Outdated
Alice and Bob starts with a shared Bell-pair entangled state. The | ||
random input x and y is provided by referee for Alice and Bob. The | ||
success probability of satisfying the above condition will be | ||
cos(theta/2)^2 if Alice and Bob measures their entangled qubit in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
measures -> measure
examples/bell_inequality.py
Outdated
Bell's theorem or inequality proves that entanglement based | ||
observations can't be reproduced with any local realist theory [1]. | ||
|
||
This example shows Bell inequality in form of CHSH game where two |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bell -> Bell's
examples/bell_inequality.py
Outdated
In the classical deterministic case, the highest probability | ||
achievable is 75%. While with quantum correlations, it can | ||
achieve higher success probability. In the quantum case, two players | ||
Alice and Bob starts with a shared Bell-pair entangled state. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
starts -> start
examples/bell_inequality.py
Outdated
random input x and y is provided by referee for Alice and Bob. The | ||
success probability of satisfying the above condition will be | ||
cos(theta/2)^2 if Alice and Bob measures their entangled qubit in | ||
measurement basis v and w where angle between v and w is theta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize "v" and "w".
examples/bell_inequality.py
Outdated
Therefore, maximum success probability is cos(pi/8)^2 ~ 85.3% | ||
when theta = pi/4. | ||
|
||
In the usual implementation [2], Alice and Bob shares the Bell state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shares -> share
@vtomole Thanks for the quick feedback, changes are done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just one minor change needed.
No description provided.