Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on bell_inequality.py example #3281

Merged
merged 8 commits into from
Sep 4, 2020

Conversation

SamarthVadia
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Aug 29, 2020
@SamarthVadia
Copy link
Contributor Author

Hi @vtomole
Check the documentation update on bell inequality example as discussed in #3032. Thanks

@vtomole vtomole self-requested a review August 31, 2020 16:47
@vtomole
Copy link
Collaborator

vtomole commented Aug 31, 2020

Thanks for opening this @SamarthVadia , I'll review it tomorrow.

Alice and Bob starts with a shared Bell-pair entangled state. The
random input x and y is provided by referee for Alice and Bob. The
success probability of satisfying the above condition will be
cos(theta/2)^2 if Alice and Bob measures their entangled qubit in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

measures -> measure

Bell's theorem or inequality proves that entanglement based
observations can't be reproduced with any local realist theory [1].

This example shows Bell inequality in form of CHSH game where two
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bell -> Bell's

In the classical deterministic case, the highest probability
achievable is 75%. While with quantum correlations, it can
achieve higher success probability. In the quantum case, two players
Alice and Bob starts with a shared Bell-pair entangled state. The
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starts -> start

random input x and y is provided by referee for Alice and Bob. The
success probability of satisfying the above condition will be
cos(theta/2)^2 if Alice and Bob measures their entangled qubit in
measurement basis v and w where angle between v and w is theta.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize "v" and "w".

Therefore, maximum success probability is cos(pi/8)^2 ~ 85.3%
when theta = pi/4.

In the usual implementation [2], Alice and Bob shares the Bell state
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shares -> share

examples/bell_inequality.py Outdated Show resolved Hide resolved
@SamarthVadia
Copy link
Contributor Author

@vtomole Thanks for the quick feedback, changes are done!

Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor change needed.

examples/bell_inequality.py Outdated Show resolved Hide resolved
@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 4, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 4, 2020
@CirqBot CirqBot merged commit 0fc057a into quantumlib:master Sep 4, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants