Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hanging docs build + bad cleanup logic #3284

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Aug 31, 2020

fix hanging docs build:

  • -j auto speeds up the sphinx build but in some cases causes the Github Actions build to hung
  • I added a flag fast to the build_rtd_docs script to make it conditional

fix cleanup logic in rtd docs build (this only comes up when you try to build things locally twice):

  • the cleanup script was removing a non-exsistant directory, I fixed it to point to ./docs

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Aug 31, 2020
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a more descriptive PR comment when you submit (similar to the comments in the PR itself should be sufficient)?

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 31, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 31, 2020
@CirqBot CirqBot merged commit 65876a9 into quantumlib:master Aug 31, 2020
@balopat balopat removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 31, 2020
@balopat
Copy link
Contributor Author

balopat commented Aug 31, 2020

You're right I should have updated it - it would have been nicer to have a more substantial commit message - I just haven't read your comment in time, and couldn't stop Cirqbot merging (we should have an undo label?:D) I added the description at least it will be in the PR description historically - I don't want to force update to master to amend the commit msg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants