added NamedQid and GridQid to the qudit concept page #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viathor
approved these changes
Sep 18, 2020
docs/qudits.ipynb
Outdated
| "While Cirq has the built-in qubit types, it also provides the corresponding Qid types: \n", | ||
| "\n", | ||
| "- `cirq.NamedQid`: To create a qutrit named 'a', specify the dimension with `cirq.NamedQid('a', dimension=3)`.\n", | ||
| "- `cirq.GridQid`: for example, to create a 2x2 grid of ququarts, use `cirq.GridQid.rect(2,2,dimension=4)`.\n", |
There was a problem hiding this comment.
nit: spaces needed after commas in the call to rect
docs/qudits.ipynb
Outdated
| "While Cirq has the built-in qubit types, it also provides the corresponding Qid types: \n", | ||
| "\n", | ||
| "- `cirq.NamedQid`: To create a qutrit named 'a', specify the dimension with `cirq.NamedQid('a', dimension=3)`.\n", | ||
| "- `cirq.GridQid`: for example, to create a 2x2 grid of ququarts, use `cirq.GridQid.rect(2,2,dimension=4)`.\n", |
There was a problem hiding this comment.
nit: Remove "for example" and capitalize "to create" for consistency with the line above.
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NamedQid and GridQid to the qudit concept page.