adding 3.7 to the tests #3348
Merged
adding 3.7 to the tests #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtomole
requested changes
Sep 21, 2020
Untitled.ipynb
Outdated
| @@ -0,0 +1,43 @@ | |||
| { | |||
vtomole
reviewed
Sep 21, 2020
| @@ -1,6 +1,6 @@ | |||
| # Runtime requirements for the python 3 version of cirq. | |||
|
|
|||
| dataclasses; python_version < '3.7' | |||
There was a problem hiding this comment.
Is this change relevant to this PR? I haven't been keeping track on if we are doing 3.8.
There was a problem hiding this comment.
This is PR is just raising the level to 3.7 i.e. < 3.8 should be fine. I've been using cirq on 3.7 for a long time now. The 3.8 work will build on top of this.
balopat
added
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To cover all python runtimes that we support, adding coverage for 3.7 besides 3.6.
With #3194 we can add 3.8 as well, and soon 3.9 hopefully to the mix.
If we agree on #3347, then we can drop 3.6 as well.