Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not perform extra optimizations in "via B" decomposition #3370

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Do not perform extra optimizations in "via B" decomposition #3370

merged 4 commits into from
Sep 30, 2020

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Sep 30, 2020

Fixes #3050.

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Sep 30, 2020
balopat
balopat approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit around tests

cirq/optimizers/two_qubit_to_fsim_test.py Show resolved Hide resolved
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 30, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 30, 2020
@CirqBot CirqBot merged commit 5029af4 into quantumlib:master Sep 30, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Sep 30, 2020
@viathor viathor deleted the no-extra-optimizations-in-via-b-decomposition branch September 30, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@Strilanc Strilanc Awaiting requested review from Strilanc

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid calling optimizers in optimizers
4 participants
@viathor @balopat @googlebot @CirqBot