New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AQT doc devices and getting started tutorial #3420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you! I added some comments.
Also, a couple more things:
- we'll need to add the headers to book.yaml
- and to readthedocs rtd_docs/index.rst.
I'd love to have Access and Authentication separated out into the Guides section that would explain the users where they can sign up and then point them to the tutorial. We'll have similar ones for Pasqal and Google as well. Basically some of the sentences from the top section of your Getting Started guide but with a little bit more explanation what they can expect - e.g. I managed to sign up with my Google account and requested a subscription (the interface was clear), but it is unclear when how I will get a token.
Edit: I just realized this was exactly the content of devices.md. I would rename devices.md to access.md and rename the title to Access and authentication
.
I'm happy to add 1 and 2 if you're okay with me pushing to your branch.
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
sure, go ahead, you can push to my branch |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes have been added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I added a next steps section as well that points to the getting started guide.
Automerge cancelled: A required status check is not present. Missing statuses: ['cla/google'] |
@googlebot please rescan |
This PR adds AQT documentation and contains a
*.md
describing how to retreive tokens and URLs of AQT devices and a Jupyter notebook on a simple getting started example which shows how to execute a basic quantum circuit via the AQT API.