Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add educators workshop heading and contents #3464

Merged
merged 16 commits into from Oct 29, 2020

Conversation

rmlarose
Copy link
Contributor

Most notebooks are for Cirq v0.5 and need updating/polishing. Putting in now as placeholder for devsite.

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Oct 29, 2020
@balopat balopat added the kind/docs Documentation related problems, ideas, requests label Oct 29, 2020
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I did merge the other ion device PR though - can you remove that from either this one or in a new PR?

@rmlarose
Copy link
Contributor Author

LGTM - I did merge the other ion device PR though - can you remove that from either this one or in a new PR?

Removed!

@rmlarose
Copy link
Contributor Author

rmlarose commented Oct 29, 2020

Failed tests due (mostly) to not including these in rtd_docs - do we want to include these in rtd_docs @balopat?

/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/chemistry.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/intro.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/ion_device.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/neutral_atom.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/qaoa_ising.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/textbook_algorithms.ipynb: WARNING: document isn't included in any toctree

@balopat
Copy link
Contributor

balopat commented Oct 29, 2020

Failed tests due (mostly) to not including these in rtd_docs - do we want to include these in rtd_docs @balopat?

/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/chemistry.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/intro.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/ion_device.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/neutral_atom.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/qaoa_ising.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/textbook_algorithms.ipynb: WARNING: document isn't included in any toctree

Let's add them under the same heading "Educator workshop" in rtd_docs/index.rst

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 29, 2020
@CirqBot
Copy link
Collaborator

CirqBot commented Oct 29, 2020

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 29, 2020
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 29, 2020
@balopat
Copy link
Contributor

balopat commented Oct 29, 2020

Failed tests due (mostly) to not including these in rtd_docs - do we want to include these in rtd_docs @balopat?

/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/chemistry.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/intro.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/ion_device.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/neutral_atom.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/qaoa_ising.ipynb: WARNING: document isn't included in any toctree
/home/runner/work/Cirq/Cirq/rtd_docs/docs/tutorials/educators/textbook_algorithms.ipynb: WARNING: document isn't included in any toctree

Let's add them under the same heading "Educator workshop" in rtd_docs/index.rst

I decided to just exclude them for now - there were too many obscure sphinx issues that I couldn't solve just now.

@CirqBot
Copy link
Collaborator

CirqBot commented Oct 29, 2020

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 29, 2020
@balopat balopat added the had-to-fight-with-the-linter Mark PR's where the linter was unreasonably annoying. label Oct 29, 2020
@balopat
Copy link
Contributor

balopat commented Oct 29, 2020

had-to-fight-with-the-linter: conf.py seems a little bit over the top to put through formatting.

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 29, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 29, 2020
@balopat balopat added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 29, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 29, 2020
@CirqBot CirqBot merged commit 862ba0a into quantumlib:master Oct 29, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining. had-to-fight-with-the-linter Mark PR's where the linter was unreasonably annoying. kind/docs Documentation related problems, ideas, requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants