Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatter on deleted or moved files #3576

Merged
merged 3 commits into from Dec 3, 2020
Merged

Fix formatter on deleted or moved files #3576

merged 3 commits into from Dec 3, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Dec 3, 2020

Fix formatter on deleted or moved files.

Fixes #3573.

@balopat balopat requested review from cduck, vtomole and a team as code owners December 3, 2020 18:35
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Dec 3, 2020
@balopat balopat requested a review from maffoo December 3, 2020 18:35
maffoo
maffoo approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@maffoo maffoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would suggest that this script is complicated enough that it might be better to rewrite it in python. But I'm biased because my bashfu is weak.

check/format-incremental Outdated Show resolved Hide resolved
@balopat
Copy link
Contributor Author

balopat commented Dec 3, 2020

+1 on moving to python for complicated scripts: #3577

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Dec 3, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Dec 3, 2020
@mpharrigan
Copy link
Collaborator

my rule is if you ever start writing a for loop in bash, stop what you're doing immediately and convert to python :)

@CirqBot CirqBot merged commit 9d7ba9c into quantumlib:master Dec 3, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maffoo maffoo maffoo approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatter script fails on moved file
4 participants
@balopat @mpharrigan @maffoo @CirqBot