Support even powers of SWAP gate in CliffordSimulator #3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #2423 |
Strilanc
reviewed
Jan 10, 2021
cirq/ops/swap_gates.py
Outdated
| args.axes = args.axes[::-1] | ||
| protocols.act_on(ops.CNOT, args) | ||
| if isinstance(args, (sim.ActOnStabilizerCHFormArgs, sim.ActOnCliffordTableauArgs)): | ||
| if not protocols.has_stabilizer_effect(self): |
There was a problem hiding this comment.
Specialize this instead of going through the general method.
There was a problem hiding this comment.
When you say specialize, do you mean to call the private method instead of protocol or inlining as you mentioned in the below comment?
| if isinstance(args, (sim.ActOnStabilizerCHFormArgs, sim.ActOnCliffordTableauArgs)): | ||
| if not protocols.has_stabilizer_effect(self): | ||
| return NotImplemented | ||
| if isinstance(args, sim.ActOnStabilizerCHFormArgs): |
There was a problem hiding this comment.
We're already in a block that has done this check.
There was a problem hiding this comment.
It could be ActOnCliffordTableauArgs
|
Friendly ping! |
Strilanc
approved these changes
Feb 1, 2021
Strilanc
added
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3659 adds support for odd powers