Add utilities that allow to characterize circuits using Floquet calibration #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the calibration progress.
# Conflicts: # cirq/google/calibration/phased_fsim.py
mrwojtek
commented
Jan 28, 2021
cirq/google/calibration/workflow.py
Outdated
| layers already calibrated and the second one the total number of layers to calibrate. | ||
|
|
||
| Returns: | ||
| Tuple of: |
There was a problem hiding this comment.
See also mrwojtek#3 (comment)
There was a problem hiding this comment.
Updated based on that conversation
mrwojtek
requested review from
cduck,
vtomole,
wcourtney and
a team
as code owners
mpharrigan
approved these changes
Jan 28, 2021
|
|
||
|
|
||
| # Workaround for: https://github.com/python/mypy/issues/5858 | ||
| def lru_cache_typesafe(func: Callable[..., T]) -> T: |
There was a problem hiding this comment.
Do we have an issue where we can record all the places where mypy makes things worse? @balopat
|
PTAL. Now make_floquet_request_for_circuit and run_floquet_characterization_for_circuit return dataclasses instead of tuples. |
|
I'm slightly blocked on this now. I'll submit it - if there are any further comments I'll create a follow-up PRs to fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two major methods:
The logic is simple and supports ISWAP ** -0.5 gates only at this moment.
There is a notion of "moments mapping" introduced which is used to connect characterization requests/results to the moments in the circuit. Alternatively this could be automated but it's not a trivial problem from the algorithmic point of view.