Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import os before using os #3733

Merged
merged 1 commit into from Feb 2, 2021
Merged

import os before using os #3733

merged 1 commit into from Feb 2, 2021

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Feb 2, 2021

Fixes #3730.

@viathor viathor requested review from cduck, vtomole, wcourtney and a team as code owners February 2, 2021 22:55
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Feb 2, 2021
mpharrigan
mpharrigan approved these changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to test for this? probably not, right?

@viathor
Copy link
Collaborator Author

viathor commented Feb 2, 2021

I think we have tests for notebooks, so there should be a way. Not sure the same is true for checking test coverage...

@balopat
Copy link
Contributor

balopat commented Feb 2, 2021

I think we have tests for notebooks, so there should be a way. Not sure the same is true for checking test coverage...

Yeah, this notebook is excluded as it uses the engine API :/
There could be a way to make notebooks somehow mockable + even do test coverage possibly but currently it's not possible to test this.

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 2, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 2, 2021
@CirqBot CirqBot merged commit 65b8638 into quantumlib:master Feb 2, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Feb 2, 2021
@viathor viathor deleted the import-os branch February 2, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpharrigan mpharrigan mpharrigan approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@wcourtney wcourtney Awaiting requested review from wcourtney

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tutorials/google/reservations] name 'os' is not defined
4 participants
@viathor @balopat @mpharrigan @CirqBot