[Docs] Patch multiplicative group in Shor tutorial #3819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
95-martin-orion
requested changes
Mar 4, 2021
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "Factoring n = pq = 184573\n", |
There was a problem hiding this comment.
What is the runtime of this factorization? If it's more than ~10 seconds, we may want to keep the outputs here to prevent delays in CI tests.
There was a problem hiding this comment.
It's fast! (due to classical order finder)
CPU times: user 2 µs, sys: 1e+03 ns, total: 3 µs
Wall time: 5.72 µs
Factoring n = pq = 184573
p = 379
q = 487
| @@ -171,9 +171,9 @@ | |||
| " Args:\n", | |||
| " n: Modulus of the multiplicative group.\n", | |||
| " \"\"\"\n", | |||
| " assert n > 2\n", | |||
| " group = [1, 2]\n", | |||
There was a problem hiding this comment.
[no change needed] I suspect this was built using the common assumption for Shor's algorithm that n is an odd number, but the new code is more generally correct. The alternative would be to add a comment explaining the Shor-based optimization being done here.
95-martin-orion
approved these changes
Mar 10, 2021
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3814. Lower priority, but the multiplicative group function (which is only used pedagogically) contained 2 sometimes when it shouldn't.
Also clears outputs so this is tested.