Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a tutorial for single/two qubit heatmaps #3880

Merged
merged 11 commits into from
Mar 18, 2021

Conversation

tanujkhattar
Copy link
Collaborator

  • Adds a tutorial for single / two qubit heatmaps

@tanujkhattar tanujkhattar requested review from cduck, vtomole and a team as code owners March 5, 2021 02:41
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Mar 5, 2021
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this tutorial Google focused. I'd split it up into two parts:

  1. Introduce a new page under Guide - Visualizations - this could have
    a.) Heatmaps
    b.) Circuit diagrams (ASCII, SVG, etc.)
    c.) later will have the bloch sphere, kak and others
  2. "Visualizing calibration metrics" would live under docs/tutorials/google

This PR could start with just point 2.)
Also:

  • Make sure to have an entry in docs/_book.yaml for it.
  • add the authentication setup to one of the cells - otherwise this is not going to run using Quantum Engine on Colab (you can just copy-paste it from docs/tutorials/colab.ipynb)

@balopat balopat changed the title Adds a tutorial for singe/two qubit heatmaps Adds a tutorial for single/two qubit heatmaps Mar 12, 2021
@tanujkhattar tanujkhattar added the Ready for Re-Review For when reviewers take their time. label Mar 15, 2021
@balopat balopat removed the Ready for Re-Review For when reviewers take their time. label Mar 17, 2021
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!! LGTM after the final nits

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 18, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 18, 2021
@CirqBot
Copy link
Collaborator

CirqBot commented Mar 18, 2021

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 18, 2021
@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 18, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 18, 2021
@CirqBot CirqBot merged commit 584b221 into quantumlib:master Mar 18, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants