Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add approximate equality for all common_channels except ResetChannel #3887

Merged
merged 7 commits into from
Mar 8, 2021
Merged

Add approximate equality for all common_channels except ResetChannel #3887

merged 7 commits into from
Mar 8, 2021

Conversation

vtomole
Copy link
Collaborator

@vtomole vtomole commented Mar 8, 2021

Fixes: #3886

@vtomole vtomole requested a review from kevinsung March 8, 2021 20:31
@vtomole vtomole requested review from cduck and a team as code owners March 8, 2021 20:31
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Mar 8, 2021
@vtomole vtomole mentioned this pull request Mar 8, 2021
Closed
@95-martin-orion
Copy link
Collaborator

It seems worthwhile (and fairly cheap) to support _approx_eq_ in the other channels as well - could you add that to this PR?

Strilanc
Strilanc approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other channels can be fixed in other PRs. No need expand the size.

@vtomole vtomole changed the title Define _approx_eq_ for cirq.depolarize() Define _approx_eq_ for all common_channels except RestChannel Mar 8, 2021
@vtomole vtomole changed the title Define _approx_eq_ for all common_channels except RestChannel Add approximate equality for all common_channels except RestChannel Mar 8, 2021
@vtomole vtomole changed the title Add approximate equality for all common_channels except RestChannel Add approximate equality for all common_channels except ResetChannel Mar 8, 2021
@vtomole vtomole merged commit 2ef656c into quantumlib:master Mar 8, 2021
@vtomole vtomole deleted the define_approx_eq_depolarizing branch March 8, 2021 22:58
@balopat balopat added the kind/bug-report Something doesn't seem to work. label Mar 9, 2021
@95-martin-orion 95-martin-orion mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strilanc Strilanc Strilanc approved these changes

@kevinsung kevinsung Awaiting requested review from kevinsung

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining. kind/bug-report Something doesn't seem to work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

common_channels don't have approximate equality.
4 participants
@vtomole @95-martin-orion @Strilanc @balopat