Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decompose_preserving_structure #3899

Merged
merged 4 commits into from
Mar 17, 2021
Merged

decompose_preserving_structure #3899

merged 4 commits into from
Mar 17, 2021

Conversation

95-martin-orion
Copy link
Collaborator

Part of #3634.

In order to send CircuitOperations to QCS, we must be able to decompose the contents of those CircuitOperations without decomposing the CircuitOperation itself. decompose_preserving_structure provides this behavior.

@95-martin-orion 95-martin-orion requested review from cduck, vtomole and a team as code owners March 10, 2021 20:13
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Mar 10, 2021
@95-martin-orion
Copy link
Collaborator Author

Per @balopat's comment _decompose_preserving_structure is now private and can be invoked with

decompose(..., preserve_structure=True)

balopat
balopat approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cirq/protocols/decompose_protocol.py Outdated Show resolved Hide resolved
@95-martin-orion @balopat
Limit preserved structure types.
52cdd92 
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
@95-martin-orion 95-martin-orion added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) labels Mar 17, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 17, 2021
@CirqBot CirqBot merged commit 2b591a5 into quantumlib:master Mar 17, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@95-martin-orion @balopat @CirqBot