Make assert_logs levels interval based #3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95-martin-orion
requested changes
Mar 15, 2021
95-martin-orion
approved these changes
Mar 15, 2021
balopat
added
the
automerge
|
Automerge cancelled: There are merge conflicts. |
CirqBot
removed
the
automerge
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames cirq.testing.assert_logs parameter
level->min_leveland adds a new parametermax_level.This is to enable more sophisticated logs assertions based on multiple levels.
===== Release note ======
cirq.testing.assert_logsparameterlevelis now deprecated and will be removed in Cirq v0.12. Please use insteadmin_level.======================