Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cirq.google dependency from three qubit gates test #3928

Merged
merged 3 commits into from
Mar 18, 2021
Merged

remove cirq.google dependency from three qubit gates test #3928

merged 3 commits into from
Mar 18, 2021

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Mar 18, 2021

Moves ValidatingTestDevice to cirq.testing and it is used in three_qubit_gates_test.
This helps removing cirq.google references from cirq.

This is related to #3737.

@balopat balopat requested review from cduck, vtomole and a team as code owners March 18, 2021 00:14
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Mar 18, 2021
@balopat balopat mentioned this pull request Mar 18, 2021
Merged
95-martin-orion
95-martin-orion approved these changes Mar 18, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nits are copyright years :P

cirq/testing/devices.py Outdated Show resolved Hide resolved
cirq/testing/devices_test.py Outdated Show resolved Hide resolved
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 18, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 18, 2021
@CirqBot CirqBot merged commit 2128257 into quantumlib:master Mar 18, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balopat @95-martin-orion @CirqBot