Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstring for cirq.QasmOutput #3934

Merged
merged 7 commits into from
Mar 22, 2021
Merged

Add docstring for cirq.QasmOutput #3934

merged 7 commits into from
Mar 22, 2021

Conversation

unaiic
Copy link
Contributor

@unaiic unaiic commented Mar 18, 2021

Adds docstring for cirq.QasmOutput and fixes formatting.

Fixes #3658.

@unaiic unaiic requested review from cduck, vtomole and a team as code owners March 18, 2021 20:04
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Mar 18, 2021
vtomole
vtomole requested changes Mar 19, 2021
View reviewed changes
cirq/circuits/qasm_output.py Outdated Show resolved Hide resolved
vtomole
vtomole reviewed Mar 19, 2021
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got one question then this should be good!

cirq/circuits/qasm_output.py Outdated Show resolved Hide resolved
vtomole
vtomole approved these changes Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 22, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 22, 2021
@CirqBot CirqBot merged commit 7aff0dd into quantumlib:master Mar 22, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docstring for cirq.QasmOutput
3 participants
@unaiic @vtomole @CirqBot