Fix name collision in program proto #3949
Conversation
balopat
requested review from
cduck,
vtomole,
wcourtney and
a team
as code owners
| @@ -276,25 +276,25 @@ message MeasurementKey { | |||
| // swap measurement keys a and b. | |||
| message MeasurementKeyMapping { | |||
| // Indicates that measurement key "key" should be replaced with "value". | |||
| message Entry { | |||
| message MeasurementKeyEntry { | |||
There was a problem hiding this comment.
For consistency, the other two should be QubitEntry and ArgEntry.
There was a problem hiding this comment.
Oh good point with the consistency - I would call this instead MeasurementKeyMappingEntry then...? Too long?
There was a problem hiding this comment.
+1 for QubitEntry, ArgEntry, MeasurementKeyEntry.
There was a problem hiding this comment.
Echoing @maffoo: these will always appear as *Mapping.<name>. We only need enough prefix to dedupe these types, so I also prefer *Entry instead of *MappingEntry.
|
Too bad that discovery api generation doesn't respect nested messages. This would seem to me to be a common problem; is there any way to change the discovery API generation to deal with this? |
IIRC, there's a similar restriction on enums in protos: even when nested, they can't have the same name. I suspect this has more to do with the fundamental behavior of protos than our API generation tools. |
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Fix name collision in program proto around
Entry-s (causes a name collision in the discovery API generation in g3).