-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update visualizing calibration metrics tutorial #3956
Update visualizing calibration metrics tutorial #3956
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some high-level comments. Is there an internal document I can compare this against?
…te_visualizating_calibration_metrics_tutorial
…ttps://github.com/tanujkhattar/Cirq into update_visualizating_calibration_metrics_tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent you the reference notebook on internal chat.
Thanks, comparison looks good. |
…te_visualizating_calibration_metrics_tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Section-level comments look good. Just a couple remaining nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final nit: let's get rid of this warning if we can:
UserWarning: Matplotlib is currently using module://ipykernel.pylab.backend_inline
Otherwise, LGTM!
This PR modifies the visualizing_calibration_metrics tutorial to make it more identical to Google's internal reports and hence more useful for our EAP users. It includes single qubit heatmaps, two qubit heatmaps and interaction histogram plots.
This also solves #3681