-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular cirq: cirq.google is extracted #3957
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
546bece
to
1a150fd
Compare
fd96791
to
ef8a487
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundle of setup.py nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from me. As double-approval has been requested on this PR, I'm leaving the final "Approve" flag-flip to Doug.
082247c
to
27dba9d
Compare
This PR extracts cirq.google into cirq_google.
This is a huge change that I don't really see how could be broken up to smaller pieces. It will probably stick around for a couple of weeks until all the downstream system's testing is done.
Major features:
pip install cirq
will install cirq, cirq-core and cirq-googlepip install cirq-google
will install cirq-core and cirq-googleTestable versions:
pip install cirq==0.11.0.dev20210323153007 --pre --index-url=https://test.pypi.org/simple --extra-index-url=https://pypi.org/simple
should install the cirq-google, cirq-core packages and the cirq metapackageThe plan: get consensus and sign-off from all major stakeholders and impacted downstream projects (cirq, qsim, quantum OS, TFQ, QCS) and then merge. I do have the changes somewhat scripted that makes it easier to keep the branch up to date with master - there is probably not going to be a need for a code freeze as such.
There are several commits that allow for easier review:
Note that this includes currently #3948 which adds an extra commit at the beginning.