Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Jupyter Notebooks in README.rst #3959

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Add link to Jupyter Notebooks in README.rst #3959

merged 5 commits into from
Mar 23, 2021

Conversation

unaiic
Copy link
Contributor

@unaiic unaiic commented Mar 23, 2021

This change adds a link to tutorials (Jupyter Notebooks) in the README.rst.

Related to #3182.

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Mar 23, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rmlarose
Copy link
Contributor

Hey @unaiic I think the notebook installs have been accounted for (see the try: import cirq cells in each notebook) and #3182 should have been closed (@balopat)?

@unaiic
Copy link
Contributor Author

unaiic commented Mar 23, 2021

Okay @rmlarose. Should I delete the PR, or is the link in the README.rst still useful?

@rmlarose
Copy link
Contributor

is the link in the README.rst still useful?

Definitely could be! I'll let others weigh in on this.

@balopat
Copy link
Contributor

balopat commented Mar 23, 2021

Hey @unaiic - sorry for keeping that issue lying around - I think that given that the new site has nicely integrated colab links, this is not really needed anymore that much. However, I still think that that colab link is a cool shortcut to all of the notebooks available in the Cirq repo. So I'm okay to merge this.

@unaiic
Copy link
Contributor Author

unaiic commented Mar 23, 2021

@balopat No problem. I also think it would be an interesting feature to have.

README.rst Outdated Show resolved Hide resolved
@unaiic unaiic changed the title Add link and runtime installation for notebooks Add link to Jupyter Notebooks in README.rst Mar 23, 2021
unaiic and others added 2 commits March 23, 2021 21:16
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 23, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 23, 2021
@CirqBot CirqBot merged commit 40bc856 into quantumlib:master Mar 23, 2021
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 23, 2021
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants