Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numpy mypy and add mypy-next #3995

Merged
merged 6 commits into from
Apr 6, 2021
Merged

Fix numpy mypy and add mypy-next #3995

merged 6 commits into from
Apr 6, 2021

Conversation

mpharrigan
Copy link
Collaborator

Towards #3767

@mpharrigan mpharrigan requested review from cduck, vtomole and a team as code owners April 6, 2021 01:32
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Apr 6, 2021
balopat
balopat suggested changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer having the next type check always exit 0.
I really don't love the comment based tagging, can we just add another line that greps on numpy?

@mpharrigan
Copy link
Collaborator Author

kk ptal @balopat

balopat
balopat approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpharrigan mpharrigan added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 6, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 6, 2021
@CirqBot CirqBot merged commit ff516d0 into quantumlib:master Apr 6, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 6, 2021
@mpharrigan mpharrigan deleted the cirq-3767-Numpy-1.20-includes-typing-information,-breaks-mypy-checks-locally branch April 6, 2021 15:43
@mpharrigan mpharrigan mentioned this pull request Apr 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining. numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpharrigan @balopat @CirqBot