Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DepolarizingChannel documentation #4011

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Fix DepolarizingChannel documentation #4011

merged 3 commits into from
Apr 12, 2021

Conversation

ryanlevy
Copy link
Contributor

@ryanlevy ryanlevy commented Apr 9, 2021

In commit fa99585 the formula for DepolarizingChannel got changed, and I'm pretty sure it should be p / (4**n - 1) \sum _i P_i \rho P_i instead, given that's what the AsymmetricDepolarizingChannel does.

@ryanlevy ryanlevy requested review from cduck, vtomole and a team as code owners April 9, 2021 13:14
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Apr 9, 2021
@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 12, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 12, 2021
@CirqBot CirqBot merged commit 83d163e into quantumlib:master Apr 12, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanlevy @95-martin-orion @CirqBot