Allow using plain qubits as keys for single-qubit heatmaps #4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
added
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…b#4028) It's a bit annoying that mypy seems to get confused unless I explicitly overload the `__init__` type signature. If I just try to type `value_map` as a `Union` type, typechecks fail at callsites. Also cleaned up a few types while I was in there, in particular we are passing around polygons as lists of (x, y) coords, not as matplotlib `Polygon` objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit annoying that mypy seems to get confused unless I explicitly overload the
__init__type signature. If I just try to typevalue_mapas aUniontype, typechecks fail at callsites.Also cleaned up a few types while I was in there, in particular we are passing around polygons as lists of (x, y) coords, not as matplotlib
Polygonobjects.