Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix omitted coverage #4036

Merged
merged 5 commits into from
Apr 21, 2021
Merged

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Apr 20, 2021

Ensures that pytest-and-incremental-coverage runs all code in the repo.

Code lines outside of cirq-google and cirq-core were not tested, so coverage check was failing. See https://github.com/quantumlib/Cirq/runs/2387098464 as an example that modifies the examples directory.

@balopat balopat requested review from cduck, vtomole and a team as code owners April 20, 2021 17:12
@balopat balopat requested a review from viathor April 20, 2021 17:12
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Apr 20, 2021
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 20, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 20, 2021
@balopat balopat changed the title Fix ommitted coverage Fix omitted coverage Apr 20, 2021
@CirqBot
Copy link
Collaborator

CirqBot commented Apr 20, 2021

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 20, 2021
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 21, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 21, 2021
@CirqBot
Copy link
Collaborator

CirqBot commented Apr 21, 2021

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 21, 2021
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 21, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 21, 2021
@balopat balopat removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 21, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 21, 2021
@CirqBot CirqBot merged commit d923a0f into quantumlib:master Apr 21, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 21, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Ensures that `pytest-and-incremental-coverage` runs all code in the repo.

Code lines outside of cirq-google and cirq-core were not tested, so coverage check was failing. See https://github.com/quantumlib/Cirq/runs/2387098464 as an example that modifies the examples directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants