Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sampler instead of engine as a primary run_calibrations runner #4054

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

mrwojtek
Copy link
Collaborator

No description provided.

@mrwojtek mrwojtek requested review from cduck, vtomole, wcourtney and a team as code owners April 26, 2021 09:23
@mrwojtek mrwojtek requested a review from balopat April 26, 2021 09:23
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Apr 26, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mrwojtek
Copy link
Collaborator Author

@mpharrigan what do you think about this? Take a look how the notebook example is simplified now.

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this looks better

@mrwojtek mrwojtek merged commit 0df0cdc into quantumlib:master Apr 27, 2021
@mrwojtek mrwojtek deleted the run_calibrations-sampler branch April 27, 2021 05:18
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…uantumlib#4054)

* Use sampler instead of engine as a primary run_calibrations runner

* Fix typing

* Fix notebook formatting

* Simplify run_calibrations further
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants