Fix google notebooks #4056
Merged
Fix google notebooks #4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
requested review from
cduck,
vtomole,
wcourtney and
a team
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
95-martin-orion
requested changes
Apr 28, 2021
There was a problem hiding this comment.
Does this also need the other changes listed in the notebooks doc?
No, because these are all exclude already from both the notebook tests, being vendor notebooks. This is the reason the bugs weren't found in the first place. |
95-martin-orion
approved these changes
Apr 28, 2021
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
The cirq_google extraction broke these notebooks - switching to `pip install cirq --pre` fixes them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cirq_google extraction broke these notebooks - switching to
pip install cirq --prefixes them.